From d09465616a3668c90bd2d98447caa8930f5fc6aa Mon Sep 17 00:00:00 2001
From: Dominic Ferrando <dominicf2001@gmail.com>
Date: Tue, 16 Sep 2025 02:07:05 -0400
Subject: [PATCH] More generator work

---
 calculator/calc.ts  | 58 +++++++++++++++++++++++++--------------------
 data/standards.json |  2 +-
 2 files changed, 33 insertions(+), 27 deletions(-)

diff --git a/calculator/calc.ts b/calculator/calc.ts
index cf8437c..c48de8c 100644
--- a/calculator/calc.ts
+++ b/calculator/calc.ts
@@ -1,4 +1,4 @@
-import { Activity, Attribute, Player, Gender, ActivityPerformance, lbToKg, clampToLevel } from "./util";
+import { Activity, Attribute, Player, Gender, ActivityPerformance, lbToKg } from "./util";
 
 // SOURCES
 // Squat, Bench, Dead Lift: 
@@ -197,47 +197,53 @@ export class Standards {
 
             const ageGenerators = allGenerators.filter(g => g.metric === "age");
             for (const ageGenerator of ageGenerators) {
+                // TODO
             }
 
             const weightGenerators = allGenerators.filter(g => g.metric === "weight");
             for (const weightGenerator of weightGenerators) {
                 for (const gender of Object.values(Gender)) {
-                    const referenceWeight = gender === Gender.Male ?
-                        lbToKg(170) :
-                        lbToKg(137);
-
                     const standardsByGender = this.byActivity(activity).byGender(gender).getAll();
                     const ages = [...new Set(standardsByGender.map(s => s.metrics.age))];
 
                     for (const age of ages) {
-                        const referenceStandard = this
-                            .byActivity(activity)
-                            .byMetrics({ weight: referenceWeight, gender: gender, age: age })
-                            .getInterpolated();
-
-                        const minWeight = referenceWeight - (referenceWeight * weightGenerator.spread);
-                        const maxWeight = referenceWeight + (referenceWeight * weightGenerator.spread);
+                        const referenceWeight = gender === Gender.Male ?
+                            lbToKg(170) :
+                            lbToKg(137);
+                        const minWeight = referenceWeight - (weightGenerator.step * weightGenerator.spread);
+                        const maxWeight = referenceWeight + (weightGenerator.step * weightGenerator.spread);
 
                         let currWeight = minWeight;
                         while (currWeight <= maxWeight) {
-                            // apply allometric scaling
-                            const newStandardLevels: Levels = {};
-                            for (const lvl in referenceStandard.levels) {
-                                const scalingExponent = .125;
-                                const coefficient = weightGenerator.ratio === "inverse" ?
-                                    referenceWeight / currWeight :
-                                    currWeight / referenceWeight;
-                                newStandardLevels[lvl] = referenceStandard.levels[lvl] * (coefficient ** scalingExponent);
-                            }
-
-                            this.activityStandards[activity].standards.push({
+                            const newStandard: Standard = {
                                 metrics: {
                                     weight: currWeight,
                                     age: age,
                                     gender: gender
                                 },
-                                levels: newStandardLevels
-                            });
+                                levels: {}
+                            };
+
+                            // apply allometric scaling to generate levels
+                            const referenceStandard = this
+                                .byActivity(activity)
+                                .byMetrics({ weight: referenceWeight, gender: gender, age: age })
+                                .getInterpolated();
+                            for (const lvl in referenceStandard.levels) {
+                                const scalingExponent = .125;
+                                const coefficient = weightGenerator.ratio === "inverse" ?
+                                    referenceWeight / currWeight :
+                                    currWeight / referenceWeight;
+                                newStandard.levels[lvl] = referenceStandard.levels[lvl] * (coefficient ** scalingExponent);
+                            }
+
+                            // prefer real data over generated data
+                            const overlappingStandard = this
+                                .byActivity(activity)
+                                .byMetrics(newStandard.metrics)
+                                .getOne();
+                            if (!overlappingStandard)
+                                this.activityStandards[activity].standards.push(newStandard);
 
                             currWeight += weightGenerator.step;
                         }
@@ -268,7 +274,7 @@ export class Standards {
                         filtered = filtered.filter((s) => s.metrics.weight === state.weight);
                     return filtered;
                 },
-                getOne: function(): Standard {
+                getOne: function(): Standard | undefined {
                     return execMethods.exact.getAll()[0];
                 },
                 getNearest(metric: NumberMetric, target: number): { lower: Standard, upper: Standard } {
diff --git a/data/standards.json b/data/standards.json
index 57276b3..e0f380c 100644
--- a/data/standards.json
+++ b/data/standards.json
@@ -4733,7 +4733,7 @@
       "generators": [
         {
           "metric": "weight",
-          "spread": 0.5,
+          "spread": 4,
           "step": 12,
           "ratio": "inverse"
         }