Implement custom retry handling of rate limit errors
This commit is contained in:
@@ -14,6 +14,7 @@ export async function up(db: Kysely<any>): Promise<void> {
|
||||
.addColumn("ended_at", "timestamptz")
|
||||
.addColumn("available_at", "timestamptz", (cb) => cb.notNull().defaultTo(sql`now()`))
|
||||
.addColumn("tries", "integer", (cb) => cb.notNull().defaultTo(0))
|
||||
.addColumn("rate_limits", "integer", (cb) => cb.notNull().defaultTo(0))
|
||||
.addColumn("has_failed", "boolean", (cb) => cb.notNull().defaultTo(false))
|
||||
.execute()
|
||||
|
||||
|
||||
@@ -7,9 +7,6 @@ import { Value } from "@sinclair/typebox/value";
|
||||
import { sql } from "kysely";
|
||||
import zipcodesUs from "zipcodes-us";
|
||||
|
||||
// TODO: read Retry-After header for how long to delay retry on 429 Too many Requests
|
||||
// https://developers.webflow.com/data/reference/rate-limits ...(do printful too)
|
||||
|
||||
export class CommerceService {
|
||||
readonly Printful = new PrintfulClient({
|
||||
token: env.PRINTFUL_AUTH,
|
||||
@@ -49,6 +46,7 @@ class ApparelOrdersService {
|
||||
processor: async (payload) => {
|
||||
const wOrder = payload.wOrder as Webflow.Orders.Order;
|
||||
|
||||
// creates a DRAFT order
|
||||
await this.Printful.Orders.create({
|
||||
external_id: wOrder.orderId,
|
||||
// TODO: derive from webflow
|
||||
@@ -69,6 +67,9 @@ class ApparelOrdersService {
|
||||
quantity: wOrderSku.count,
|
||||
})),
|
||||
});
|
||||
|
||||
// TODO: confirm the above created order
|
||||
// right now we manually review and confirm it in the printful portal
|
||||
}
|
||||
}),
|
||||
"apparel_order_fulfill": defineEventType({
|
||||
|
||||
@@ -5,6 +5,7 @@ import { sleep } from "bun";
|
||||
import { db } from "../database/db";
|
||||
import { AssertError, Value } from "@sinclair/typebox/value";
|
||||
import type { TSchema, Static } from "@sinclair/typebox";
|
||||
import { RateLimitError } from "@blade-and-brawn/domain";
|
||||
|
||||
export type EventSource = "portal" | "printful" | "webflow";
|
||||
export type EventStatus = "waiting" | "available" | "processing" | "failed" | "fulfilled";
|
||||
@@ -38,6 +39,7 @@ export function defineEventType<P extends TSchema, S extends TSchema>(opt: Event
|
||||
export class EventQueue<G extends string, T extends Record<string, EventTypeOptions<any, any>>> {
|
||||
private static readonly DEQUEUE_RETRY_DELAY_MS = 10000; // 10 seconds
|
||||
private static readonly DEQUEUE_RETRY_LIMIT = 3;
|
||||
private static readonly RATE_LIMIT_RETRY_LIMIT = 15;
|
||||
|
||||
private _lastCleanDate: Date = new Date(0);
|
||||
readonly cfg: EventQueueCfg;
|
||||
@@ -179,7 +181,7 @@ export class EventQueue<G extends string, T extends Record<string, EventTypeOpti
|
||||
|
||||
async front(trx?: Transaction<DB>) {
|
||||
const result = await (trx ?? db).selectFrom("events")
|
||||
.select(["id", "type", "payload", "available_at", "tries"])
|
||||
.select(["id", "type", "payload", "available_at", "tries", "rate_limits"])
|
||||
.where("group", "=", this.group)
|
||||
.where("started_at", "is", null)
|
||||
.where("available_at", "<=", new Date())
|
||||
@@ -220,7 +222,7 @@ export class EventQueue<G extends string, T extends Record<string, EventTypeOpti
|
||||
.execute();
|
||||
}
|
||||
|
||||
private async processEvent(event: Pick<Selectable<DB["events"]>, "id" | "type" | "tries" | "payload">) {
|
||||
private async processEvent(event: Pick<Selectable<DB["events"]>, "id" | "type" | "tries" | "payload" | "rate_limits">) {
|
||||
log.info({ id: event.id, type: event.type, payload: event.payload }, "processing event");
|
||||
if (!(event.type in this.events)) throw new Error(`event type not registered in this queue (${this.group}): ${event.type}`);
|
||||
const cfg = this.events[event.type as keyof T]!;
|
||||
@@ -231,15 +233,24 @@ export class EventQueue<G extends string, T extends Record<string, EventTypeOpti
|
||||
await this.fulfill(event.id);
|
||||
}
|
||||
catch (err) {
|
||||
if (err instanceof RateLimitError && event.rate_limits < EventQueue.RATE_LIMIT_RETRY_LIMIT) {
|
||||
log.warn(
|
||||
{ tries: event.tries, delay: err.retryDelayMs, source: err.source, payload: err.payload },
|
||||
"encountered a rate limit error"
|
||||
);
|
||||
await this.retry(event.id, err.retryDelayMs, { isRateLimit: true });
|
||||
return;
|
||||
}
|
||||
|
||||
if (err instanceof AssertError) {
|
||||
log.error({ tries: event.tries }, "could not process event: malformed payload");
|
||||
await this.fail(event.id);
|
||||
return;
|
||||
}
|
||||
|
||||
if (event.tries < this.cfg.retry.limit) {
|
||||
if ((event.tries - event.rate_limits) < this.cfg.retry.limit) {
|
||||
log.warn({ err, tries: event.tries, delay: this.cfg.retry.delayMs }, "encountered an error during event processing, retrying")
|
||||
await this.retry(event.id);
|
||||
await this.retry(event.id, this.cfg.retry.delayMs);
|
||||
return;
|
||||
}
|
||||
|
||||
@@ -255,14 +266,15 @@ export class EventQueue<G extends string, T extends Record<string, EventTypeOpti
|
||||
.execute();
|
||||
}
|
||||
|
||||
private async retry(id: string) {
|
||||
private async retry(id: string, delayMs: number, opt: { isRateLimit?: boolean } = {}) {
|
||||
await db.updateTable("events")
|
||||
.set((eb) => ({
|
||||
tries: eb("tries", "+", 1),
|
||||
rate_limits: opt.isRateLimit ? eb("rate_limits", "+", 1) : eb.ref("rate_limits"),
|
||||
started_at: null,
|
||||
ended_at: null,
|
||||
has_failed: false,
|
||||
available_at: new Date(Date.now() + this.cfg.retry.delayMs)
|
||||
available_at: new Date(Date.now() + delayMs)
|
||||
}))
|
||||
.where("id", "=", id)
|
||||
.execute();
|
||||
|
||||
Reference in New Issue
Block a user